-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set current location from request service point for 'awaiting pickup' items #1020
Conversation
eb92274
to
0906b8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm you've run this with the folio_postgres_reader_spec.rb and the time isn't adversely affected?
end | ||
|
||
# ARS-LOAN, RUM-LOAN, and SPE-LOAN each receives a | ||
# special label in SearchWorks. Other codes are generically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where will these labels come from in Searchworks? Aren't we moving toward using Folio location labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equivalent in FOLIO for these locations would be service points, which I don't think we're doing anything with in SearchWorks yet. We might want to. But this gets us to parity with Symphony by relying on the existing Constants:LOCS
mappings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the intention is to remove Constants::LOCS
after migrating to Folio, so we need to handle these in some other way. (see sul-dlss/SearchWorks#3310)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbeer I'm confused about what the plan is for Constants::LOCS
vs FOLIO display names. My guess is we're still going to have location codes that don't map to anything in FOLIO and we'll need to maintain a fallback list in SearchWorks (maybe I'm wrong about this). This PR is a refinement to previous work to map folio statuses to symphony locations so they'll display right in searchworks. Is this no longer what we want to do?
See:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to capture post-folio work related to this in #1026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we going to be moving away from item_display and towards using item_display_struct? Do we need this change there as well?
No additional change is needed. This is modifying the |
It's still within the expected range of 30 to 90 seconds:
|
d18fb82
to
c6a27c7
Compare
Closes #974